feat: epoch notifier #144
Merged
feat: epoch notifier #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaubennassar
requested changes
Oct 28, 2024
vcastellm
reviewed
Oct 29, 2024
goran-ethernal
approved these changes
Oct 31, 2024
goran-ethernal
approved these changes
Oct 31, 2024
joanestebanr
force-pushed
the
feature/epoch_notifier
branch
2 times, most recently
from
cda1666 to
68f4aaf
Compare
arnaubennassar
approved these changes
Nov 4, 2024
vcastellm
reviewed
Nov 4, 2024
joanestebanr
force-pushed
the
feature/epoch_notifier
branch
from
6836886 to
0b8ba05
Compare
vcastellm
reviewed
Nov 11, 2024
vcastellm
reviewed
Nov 11, 2024
vcastellm
reviewed
Nov 11, 2024
vcastellm
requested changes
Nov 11, 2024
|
vcastellm
approved these changes
Nov 12, 2024
joanestebanr
added a commit
that referenced
this pull request
Nov 12, 2024
* feat: unpack and log agglayer errors (#158) * feat: unpack and log agglayer errors * feat: agglayer error unpacking * fix: lint and UT * feat: epoch notifier (#144) - Send certificates after a percentage of epoch - Require epoch configuration to AggLayer - Change config of `aggsender` adding: `BlockFinality` and `EpochNotificationPercentage` * refact: GetSequence method (#169) * feat: remove sanity check (#178) (#179) --------- Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com> Co-authored-by: Rachit Sonthalia <54906134+rachit77@users.noreply.github.com> Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Vui-Chee
added a commit
to okx/xlayer-cdk
that referenced
this pull request
Dec 3, 2024
* tag 'v0.5.0-beta6': feat: write on database the number of retries per certificate and the certificates in a history table (0xPolygon#208) feat: return an error in case agglayer returns certificate with height lower than in local storage (0xPolygon#209) chore: simplify the `HashMeddler` (0xPolygon#205) fix: clean proof table on start (0xPolygon#207) (0xPolygon#210) feat: improve logs (0xPolygon#204) fix: cdk603 error calculating previousLocalExitRoot (0xPolygon#199) fix: Integration Bali PP (0xPolygon#198) feat: check agglayer certificate and use as initial if db is empty (0xPolygon#192) feat: sqlite aggregator (0xPolygon#189) feat: BridgeMessage e2e test (0xPolygon#184) feat: aggsender e2e (0xPolygon#183) fix: aggregating proofs (0xPolygon#191) (0xPolygon#193) feat: l1infotreesync can be run as individual component (0xPolygon#188) fix: l1infotree flaky test (0xPolygon#182) fix: `L1InfoRootIncorrect` error from `agglayer` (0xPolygon#185) feat: improve aggsender logs (0xPolygon#186) (0xPolygon#187) feat: remove sanity check (0xPolygon#178) (0xPolygon#179) refact: GetSequence method (0xPolygon#169) feat: epoch notifier (0xPolygon#144) feat: unpack and log agglayer errors (0xPolygon#158)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AggLayerrequire 1 certificate per network each epoch. So the idea is before closing the current AggLayer epoch send the certificate. To do that we add a new object `interop_getClockConfigurationBlockNotifierInternals
aggsenderwithout_mocksuffix on filenameConfiguration changes:
None of this new fields are mandatory, you can use default ones.
BlockFinality: is the point that we check the block to decice the epoch. CurrentlyAggLayeris using latestEpochNotificationPercentage: It generate a new certificateBlocksBeforeEpochEndingblocks after reaching this percentage of epoch. Percent is 0 begining, 100 endTests
ghcr.io/agglayer/agglayer:0.2.0-rc.9